saxenapranav commented on code in PR #5446:
URL: https://github.com/apache/hadoop/pull/5446#discussion_r1130357512


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -222,6 +224,10 @@ AbfsThrottlingIntercept getIntercept() {
     return intercept;
   }
 
+  boolean shouldThrottleRetries() {
+    return throttleRetries;
+  }
+

Review Comment:
   Either of two is fine.
   if we keep in abfsClient, it will be stored account level, and we dont need 
to check anything till abfsClient object is alived. In abfsRestOp, new field 
will be created as new object is created for each api call.
   if we keep it in abfsRestOperation, it is something which is actually 
requried in abfsRestOperation. Though it doesn't matter. You may please resolve 
this comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to