[
https://issues.apache.org/jira/browse/HADOOP-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698157#comment-17698157
]
ASF GitHub Bot commented on HADOOP-18640:
-----------------------------------------
saxenapranav commented on code in PR #5446:
URL: https://github.com/apache/hadoop/pull/5446#discussion_r1130357512
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -222,6 +224,10 @@ AbfsThrottlingIntercept getIntercept() {
return intercept;
}
+ boolean shouldThrottleRetries() {
+ return throttleRetries;
+ }
+
Review Comment:
Either of two is fine.
if we keep in abfsClient, it will be stored account level, and we dont need
to check anything till abfsClient object is alived. In abfsRestOp, new field
will be created as new object is created for each api call.
if we keep it in abfsRestOperation, it is something which is actually
requried in abfsRestOperation. Though it doesn't matter. You may please resolve
this comment.
> ABFS: Enabling Client-side Backoff only for new requests
> --------------------------------------------------------
>
> Key: HADOOP-18640
> URL: https://issues.apache.org/jira/browse/HADOOP-18640
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Reporter: Sree Bhattacharyya
> Assignee: Sree Bhattacharyya
> Priority: Minor
> Labels: pull-request-available
>
> Enabling backoff only for new requests that happen, and disabling for retried
> requests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
