virajjasani commented on PR #5469: URL: https://github.com/apache/hadoop/pull/5469#issuecomment-1462592962
I don't have much insights into Yarn federation but it looks like Yarn does have `SQLFederationStateStore` (it uses `HikariDataSource`) and one of the impl `MySQLFederationStateStore` is in test code. Perhaps keeping MySQL specific impl in test was meant to be set as an example only? @slfan1989 might have better insights. I don't mean anything against this change btw, I just wonder how we could manage ever increasing num of external dependencies such that we could allow more pluggable implementation to be used by different users without hadoop having to take up more external dependencies :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
