virajjasani commented on code in PR #5456:
URL: https://github.com/apache/hadoop/pull/5456#discussion_r1132698272
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java:
##########
@@ -103,14 +113,15 @@ public static boolean isLog4jLogger(Class<?> clazz) {
* @return true if the logger uses Log4J implementation.
*/
public static boolean isLog4jLogger(String logger) {
- if (logger == null) {
+ if (logger == null || !IS_LOG4J_LOGGER.get()) {
return false;
}
Logger log = LoggerFactory.getLogger(logger);
try {
Review Comment:
I think the other way around would be more appropriate?
For instance, in slf4j implementation, they have:
```
public static Logger getLogger(Class<?> clazz) {
Logger logger = getLogger(clazz.getName());
...
...
```
Hence, we can also call clazz.getName() here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
