ayushtkn commented on PR #5460: URL: https://github.com/apache/hadoop/pull/5460#issuecomment-1468343688
> But will the checkstyle not affect all future PRs? I think I have seen that happen before, where a new checkstyle issue comes in, and then future PRs are impacted by it, but I may be wrong. How? You folks mean the new PR will also show this checstyle warning? So, our checkstyle works by computing diff b/w the trunk and the patch and flags when the number changes. if you check the warning above: ``` hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 79 unchanged - 0 fixed = 81 total (was 79) ``` There were already 79, the PR had 2 more, so that is what it flags -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
