mkuchenbecker commented on code in PR #5479:
URL: https://github.com/apache/hadoop/pull/5479#discussion_r1137608854
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java:
##########
@@ -323,10 +323,10 @@ public void addIncrementalBlockReport(long latency,
}
}
- public void addReadTransferRate(long readTransferRate) {
- this.readTransferRate.add(readTransferRate);
- for (MutableQuantiles q : readTransferRateQuantiles) {
- q.add(readTransferRate);
+ public void addReadLatencyPerGB(long readLatencyPerGB) {
+ this.readLatencyPerGB.add(readLatencyPerGB);
+ for (MutableQuantiles q : readLatencyPerGBQuantiles) {
Review Comment:
Why don't we modify these quantiles rather than the metric?
I think we have the metric we want, but we want the `lowest` vs `highest`
percentile (ts clear the current percentile is lower=better).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
