[
https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701217#comment-17701217
]
ASF GitHub Bot commented on HADOOP-18146:
-----------------------------------------
steveloughran commented on code in PR #4039:
URL: https://github.com/apache/hadoop/pull/4039#discussion_r1138820601
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -702,7 +707,7 @@ public AbfsRestOperation append(final String path, final
byte[] buffer,
*/
int responseStatusCode = ((AbfsRestOperationException)
e).getStatusCode();
if (checkUserError(responseStatusCode) &&
reqParams.isExpectHeaderEnabled()) {
- LOG.debug("User error, retrying without 100 continue enabled");
+ LOG.debug("User error, retrying without 100 continue enabled for the
given path " + path);
Review Comment:
nit; use {} in the string, path as an argument
* skips string concat when logging doesn't take place
* if path is null, triggers error on toString(), logging recovers
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientThrottlingIntercept.java:
##########
@@ -160,7 +160,7 @@ public void updateMetrics(AbfsRestOperationType
operationType,
throttling but there were some expectedBytesToBeSent.
*/
if (updateBytesTransferred(isThrottledOperation, abfsHttpOperation))
{
- LOG.debug("Updating metrics due to throttling");
+ LOG.debug("Updating metrics due to throttling for path " +
abfsHttpOperation.getConnUrl().getPath());
Review Comment:
same thing about {}
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClient.java:
##########
@@ -579,8 +577,6 @@ public void testExpectHundredContinue() throws Exception {
.isEqualTo(0);
// Verify that the same request was retried with expect header disabled.
- Assertions.assertThat(appendRequestParameters.isExpectHeaderEnabled())
- .describedAs("The expect header is not false")
- .isEqualTo(false);
+ assertFalse(appendRequestParameters.isExpectHeaderEnabled());
Review Comment:
sorry, i must have explained it wrong. AssertJ has assert/true false too in
its type `AbstractBooleanAssert`. you can go
```
Assertions.assertThat(appendRequestParameters.isExpectHeaderEnabled())
.describedAs("The expect header is not false")
.isFalse()
```
so can you restore what was cut and just change the assert.
```
> ABFS: Add changes for expect hundred continue header with append requests
> -------------------------------------------------------------------------
>
> Key: HADOOP-18146
> URL: https://issues.apache.org/jira/browse/HADOOP-18146
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.3.1
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Heavy load from a Hadoop cluster lead to high resource utilization at FE
> nodes. Investigations from the server side indicate payload buffering at
> Http.Sys as the cause. Payload of requests that eventually fail due to
> throttling limits are also getting buffered, as its triggered before FE could
> start request processing.
> Approach: Client sends Append Http request with Expect header, but holds back
> on payload transmission until server replies back with HTTP 100. We add this
> header for all append requests so as to reduce.
> We made several workload runs with and without hundred continue enabled and
> the overall observation is that :-
> # The ratio of TCP SYN packet count with and without expect hundred continue
> enabled is 0.32 : 3 on average.
> # The ingress into the machine at TCP level is almost 3 times lesser with
> hundred continue enabled which implies a lot of bandwidth save.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
