rdingankar commented on code in PR #5486:
URL: https://github.com/apache/hadoop/pull/5486#discussion_r1140539922


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java:
##########
@@ -104,8 +105,7 @@ public MutableQuantiles(String name, String description, 
String sampleName,
           String.format(descTemplate, percentile));
     }
 
-    estimator = new SampleQuantiles(quantiles);
-
+    estimator = inverseQuantiles ? new InverseQuantiles(quantiles) : new 
SampleQuantiles(quantiles);

Review Comment:
   yes, estimator is the one which will sort the sample and populate quantiles.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to