virajjasani commented on PR #5487: URL: https://github.com/apache/hadoop/pull/5487#issuecomment-1474376435
> > Do we have this exit code output being 0 in 3.3.X? > > If it hasn't been released it is fine but I suspect it has. > > It is there since very starting, even in branch-2.9 https://github.com/apache/hadoop/blob/branch-2.9/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java#L182-L185 > > There ain't any release line which has not released this behaviour :) On the above reference of branch-2.9, though even `-add` and `-update` are of same behavior. That means all commands are exiting with status code 0 even for failures, so while not intended behavior, at least they all are consistent in that sense. Whereas right now on 3.3, `-add` and `-update` have different behavior (which is correct with outside world) than `-rm` etc, which is inconsistent already. It's like some of router admin CLI options have correct behavior from outside world viewpoint but others don't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
