[ 
https://issues.apache.org/jira/browse/HADOOP-18669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702063#comment-17702063
 ] 

ASF GitHub Bot commented on HADOOP-18669:
-----------------------------------------

virajjasani opened a new pull request, #5493:
URL: https://github.com/apache/hadoop/pull/5493

   Log4Json extends org.apache.log4j.Layout to provide log layout for Json. 
This utility is not being used anywhere in Hadoop. It is IA.Private (by 
default).
   
   Log4j2 has introduced drastic changes to the Layout. It also converted it as 
an interface. Log4j2 also has JsonLayout, it provides options like Pretty vs. 
compact JSON, Encoding UTF-8 or UTF-16, Complete well-formed JSON vs. fragment 
JSON, addition of custom fields into generated JSON
   
https://github.com/apache/logging-log4j2/blob/2.x/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/JsonLayout.java
   
   
   This utility is more suitable to be part of log4j project rather than hadoop 
because the maintenance cost in hadoop would be higher with any more upgrades 
introducing changes to the Layout format.




> Remove Log4Json Layout
> ----------------------
>
>                 Key: HADOOP-18669
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18669
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>
> Log4Json extends org.apache.log4j.Layout to provide log layout for Json. This 
> utility is not being used anywhere in Hadoop. It is IA.Private (by default).
> Log4j2 has introduced drastic changes to the Layout. It also converted it as 
> an interface. Log4j2 also has JsonLayout, it provides options like Pretty vs. 
> compact JSON, Encoding UTF-8 or UTF-16, Complete well-formed JSON vs. 
> fragment JSON, addition of custom fields into generated JSON
> [https://github.com/apache/logging-log4j2/blob/2.x/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/JsonLayout.java]
>  
> This utility is more suitable to be part of log4j project rather than hadoop 
> because the maintenance cost in hadoop would be higher with any more upgrades 
> introducing changes to the Layout format.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to