tasanuma commented on PR #5480: URL: https://github.com/apache/hadoop/pull/5480#issuecomment-1475612258
Thanks for creating the unit test, @eubnara. The changes mostly seem good to me. - In the unit test, could you use allowList and denyList for the variable names? Although we cannot change the name of `hadoop.http.authentication.kerberos.endpoint.whitelist` to keep the backward compatibility, we are trying to remove non-inclusive terminology as much as possible. ( [HADOOP-17168](https://issues.apache.org/jira/browse/HADOOP-17168) ) - Could you fix the checkstyle issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
