[
https://issues.apache.org/jira/browse/HADOOP-18425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702928#comment-17702928
]
ASF GitHub Bot commented on HADOOP-18425:
-----------------------------------------
steveloughran commented on PR #5494:
URL: https://github.com/apache/hadoop/pull/5494#issuecomment-1476907289
so hdfs returns false if source not found, or dest exists
```xml
<property>
<name>fs.contract.rename-returns-false-if-dest-exists</name>
<value>true</value>
</property>
<property>
<name>fs.contract.rename-returns-false-if-source-missing</name>
<value>true</value>
</property>
```
abfs does the same.
s3a client blows up with meaningful errors
```xml
<property>
<name>fs.contract.rename-returns-false-if-source-missing</name>
<value>false</value>
</property>
<property>
<name>fs.contract.rename-returns-false-if-dest-exists</name>
<value>false</value>
</property>
```
I'm more in favour of the "blow up" strategy; if you look at almost all uses
of rename it is code like:
```java
if (!rename(src, dest)) throw new Exception("rename failed we don't know
why")p
```
and nobody ever seems to complain about the s3a failure...but then of course
rename is broken there for other reasons, so maybe code just avoids it (e.g.
committers).
> [ABFS]: RenameFilePath Source File Not Found (404) error in retry loop
> ----------------------------------------------------------------------
>
> Key: HADOOP-18425
> URL: https://issues.apache.org/jira/browse/HADOOP-18425
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Reporter: Sree Bhattacharyya
> Assignee: Sree Bhattacharyya
> Priority: Minor
> Labels: pull-request-available
>
> RenameFilePath on its first try receives a Request timed out error with code
> 500. On retrying the same operation, a Source file not found (404) error is
> received.
> Possible mitigation: Check whether etags remain the same before and after the
> retry and accordingly send an Operation Successful result, instead of source
> file not found.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
