slfan1989 commented on code in PR #5420:
URL: https://github.com/apache/hadoop/pull/5420#discussion_r1143403863
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##########
@@ -586,37 +583,31 @@ private Response
invokeSubmitApplication(ApplicationSubmissionContextInfo submis
* operation.
*/
@Override
- public AppInfo getApp(HttpServletRequest hsr, String appId,
- Set<String> unselectedFields) {
+ public AppInfo getApp(HttpServletRequest hsr, String appId, Set<String>
unselectedFields) {
long startTime = clock.getTime();
- ApplicationId applicationId = null;
try {
- applicationId = ApplicationId.fromString(appId);
+ ApplicationId.fromString(appId);
Review Comment:
Thanks for the reminder, I will improve this part of the code again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
