[
https://issues.apache.org/jira/browse/HADOOP-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703652#comment-17703652
]
ASF GitHub Bot commented on HADOOP-18012:
-----------------------------------------
sreeb-msft commented on PR #5488:
URL: https://github.com/apache/hadoop/pull/5488#issuecomment-1479533842
> commented.
>
> @sreeb-msft the changes in my patch are all on top of your commit
#e8ce29ffce5 ; you should be able to cherry pick them from my branch directly
onto your commit, then you can rebase all later changes on top.
>
> that way, I can then pick up your changes and apply them to mine...this is
how we can codevelop a branch just by
>
> * adding each others github repos as remotes
> * using git fetch to fetch
> * then git cherrypick
> this is how i got pranav's changes in, and it should work here too.
>
> can you do that then look at my comments? thanks
Have cherry-picked your changes and pushed the updates after resolving
conflicts. Let me know if I should do anything different.
> ABFS: Enable config controlled ETag check for Rename idempotency
> ----------------------------------------------------------------
>
> Key: HADOOP-18012
> URL: https://issues.apache.org/jira/browse/HADOOP-18012
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.2
> Reporter: Sneha Vijayarajan
> Assignee: Sree Bhattacharyya
> Priority: Major
> Labels: pull-request-available
>
> ABFS driver has a handling for rename idempotency which relies on LMT of the
> destination file to conclude if the rename was successful or not when source
> file is absent and if the rename request had entered retry loop.
> This handling is incorrect as LMT of the destination does not change on
> rename.
> This Jira will track the change to undo the current implementation and add a
> new one where for an incoming rename operation, source file eTag is fetched
> first and then rename is done only if eTag matches for the source file.
> As this is going to be a costly operation given an extra HEAD request is
> added to each rename, this implementation will be guarded over a config and
> can enabled by customers who have workloads that do multiple renames.
> Long term plan to handle rename idempotency without HEAD request is being
> discussed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
