sreeb-msft commented on code in PR #5488:
URL: https://github.com/apache/hadoop/pull/5488#discussion_r1146105616
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -535,12 +537,14 @@ public Pair<Boolean, Duration> commitSingleFileByRename(
throw new PathIOException(qualifiedSrcPath.toString(), "cannot rename
object onto self");
}
+ boolean isNamespaceEnabled =
abfsStore.getIsNamespaceEnabled(tracingContext);
Review Comment:
This needs the tracingContext to be passed as a parameter, which is not
meaningful to be created in the initialize method, as it needs params like
operation type also. Hence, have kept in the individual methods itself, to use
up the tracing context actually created in the API methods.
Would it be better to create a dummy tracing context then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
