virajjasani commented on PR #5497: URL: https://github.com/apache/hadoop/pull/5497#issuecomment-1483884585
For the test, if we want to be accurate about `mountTableCacheLoadAvgTimeMs`, there is a better way too: we can use `FakeTimer` impl and inject it to `CachedRecordStore` by retrieving state store cache list `cachesToUpdateInternal` from the state store service. I think this might be overkill for the current Jira though. If you like this idea, I can take it up as separate task, but for prod, we are not achieving anything and maybe this is too much for tests as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
