goiri commented on code in PR #4963:
URL: https://github.com/apache/hadoop/pull/4963#discussion_r1149505746
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##########
@@ -283,154 +290,229 @@ public void checkVersion() throws Exception {
@Override
public GetSubClusterPolicyConfigurationResponse getPolicyConfiguration(
GetSubClusterPolicyConfigurationRequest request) throws YarnException {
- return stateStoreClient.getPolicyConfiguration(request);
+ FederationClientMethod clientMethod = new FederationClientMethod(
Review Comment:
Or actually just specify it as an arg:
```
FederationClientMethod clientMethod = new FederationClientMethod(
"getPolicyConfiguration", GetSubClusterPolicyConfigurationRequest.class,
request,
GetSubClusterPolicyConfigurationResponse.class,
stateStoreClient, clock);
```
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##########
@@ -283,154 +290,229 @@ public void checkVersion() throws Exception {
@Override
public GetSubClusterPolicyConfigurationResponse getPolicyConfiguration(
GetSubClusterPolicyConfigurationRequest request) throws YarnException {
- return stateStoreClient.getPolicyConfiguration(request);
+ FederationClientMethod clientMethod = new FederationClientMethod(
Review Comment:
Wouldn't it make more sense to make it:
```
FederationClientMethod<GetSubClusterPolicyConfigurationResponse>
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
