rdingankar commented on code in PR #5495:
URL: https://github.com/apache/hadoop/pull/5495#discussion_r1152326777


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java:
##########
@@ -162,7 +206,7 @@ public synchronized void setEstimator(QuantileEstimator 
quantileEstimator) {
    * Runnable used to periodically roll over the internal
    * {@link SampleQuantiles} every interval.
    */
-  private static class RolloverSample implements Runnable {
+  static class RolloverSample implements Runnable {

Review Comment:
   The scope is widened for the class to be accessible from subclass 
`InversePercentile` and not for Test purposes, so not adding the annotation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to