simbadzina commented on code in PR #5469: URL: https://github.com/apache/hadoop/pull/5469#discussion_r1155038678
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/StateStoreDriver.java: ########## @@ -35,6 +36,7 @@ * provider. Driver implementations will extend this class and implement some of * the default methods. */ [email protected] Review Comment: It is possible to statically import Public, but I think it makes the code less readable having just `@Public` vs `@InterfaceAudience.Public`. The oracle documentation also only recommends static imports when there is frequent access to the value. https://docs.oracle.com/javase/7/docs/technotes/guides/language/static-import.html#:~:text=So%20when%20should%20you%20use,from%20one%20or%20two%20classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
