rdingankar commented on code in PR #5495:
URL: https://github.com/apache/hadoop/pull/5495#discussion_r1156218481
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/util/TestSampleQuantiles.java:
##########
@@ -91,28 +93,70 @@ public void testClear() throws IOException {
@Test
public void testQuantileError() throws IOException {
final int count = 100000;
- Random r = new Random(0xDEADDEAD);
- Long[] values = new Long[count];
+ Random rnd = new Random(0xDEADDEAD);
+ int[] values = new int[count];
Review Comment:
int[] is sufficient here. It also saves us from typecasting the values at
L99.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
