virajjasani commented on code in PR #5523:
URL: https://github.com/apache/hadoop/pull/5523#discussion_r1156438980
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##########
@@ -137,6 +149,8 @@ public abstract <T extends BaseRecord> BufferedWriter
getWriter(
*/
protected abstract String getRootDir();
+ protected abstract int getConcurrentFilesAccessNumThreads();
Review Comment:
I believe separate configs would be better since we anyways have different
implementation for many of other methods too. Sounds good to keep it as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]