Hexiaoqiao commented on code in PR #4435:
URL: https://github.com/apache/hadoop/pull/4435#discussion_r1161241461
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -819,6 +819,15 @@ public static boolean isAclEnabled(Configuration conf) {
public static final int DEFAULT_RM_DT_RENEWER_THREAD_RETRY_MAX_ATTEMPTS =
10;
+ /**
+ * The setting is used to control delegation token renewer thread perform
backoff
+ * waiting when there are no renewer event futures to avoid CPU busy idling.
+ */
+ public static final String RM_DT_RENEWER_THREAD_IDLE_BACKOFF_MS =
+ RM_PREFIX + "delegation-token-renewer.thread-idle-backoff-ms";
+ public static final long DEFAULT_RM_DT_RENEWER_THREAD_IDLE_BACKOFF_MS =
+ TimeUnit.SECONDS.toMillis(3); // 3 Seconds
Review Comment:
Just suggest to change `TimeUnit.SECONDS.toMillis(3)` to 180000 directly to
keep same dimension as Key/Value name says (MS/ms) and avoid ambiguity for end
user.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml:
##########
@@ -1148,6 +1148,16 @@
<value>60s</value>
</property>
+ <property>
+ <description>
+ The setting is used to control each RM DelegationTokenRenewer thread
perform backoff
+ waiting when there are no renewer event futures to avoid CPU busy idling.
+ the default value is 3 seconds.
+ </description>
+
<name>yarn.resourcemanager.delegation-token-renewer.thread-idle-backoff-ms</name>
+ <value>3s</value>
Review Comment:
+1 as mentioned above. We should keep the same dimension for both key and
value of configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
