goiri commented on code in PR #4687:
URL: https://github.com/apache/hadoop/pull/4687#discussion_r1155032724
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java:
##########
@@ -324,10 +329,66 @@ public void serviceInit(Configuration conf) throws
Exception {
YarnConfiguration.DEFAULT_NM_PROCESS_KILL_WAIT_MS) +
SHUTDOWN_CLEANUP_SLOP_MS;
+ nmDispatherMetricEnabled = conf.getBoolean(
+ YarnConfiguration.NM_DISPATCHER_METRIC_ENABLED,
+ YarnConfiguration.DEFAULT_NM_DISPATCHER_METRIC_ENABLED);
+
super.serviceInit(conf);
recover();
}
+ @SuppressWarnings("unchecked")
+ protected AsyncDispatcher createContainerManagerDispatcher() {
+ dispatcher = new AsyncDispatcher("NM ContainerManager dispatcher");
+
+ if (nmDispatherMetricEnabled) {
Review Comment:
Maybe easier to read as:
```
if (!nmDispatherMetricEnabled) {
return dispatcher;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
