mukund-thakur commented on code in PR #5543:
URL: https://github.com/apache/hadoop/pull/5543#discussion_r1163358833
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ADataBlocks.java:
##########
@@ -849,14 +855,29 @@ long dataSize() {
return bytesWritten;
}
+ /**
+ * Does this block have unlimited space?
+ * @return true if a block with no size limit was created.
+ */
+ private boolean unlimited() {
+ return limit < 0;
+ }
+
@Override
boolean hasCapacity(long bytes) {
- return dataSize() + bytes <= limit;
+ return unlimited() || dataSize() + bytes <= limit;
}
+ /**
+ * {@inheritDoc}.
+ * If there is no limit to capacity, return MAX_VALUE.
+ * @return capacity in the block.
+ */
@Override
long remainingCapacity() {
- return limit - bytesWritten;
+ return unlimited()
Review Comment:
remainingCapacity is long so shouldn't it be long.MAX_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
