melissayou commented on code in PR #5536:
URL: https://github.com/apache/hadoop/pull/5536#discussion_r1164453134
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemStorageStatistics.java:
##########
@@ -74,6 +75,7 @@ public void setup() {
statistics.incrementBytesReadByDistance(1, RandomUtils.nextInt(0, 100));
statistics.incrementBytesReadByDistance(3, RandomUtils.nextInt(0, 100));
statistics.incrementBytesReadErasureCoded(RandomUtils.nextInt(0, 100));
+ statistics.increaseRemoteBytesReadTime(RandomUtils.nextInt(0, 100));
Review Comment:
The existing test method `testGetLongStatistics` and `testGetLong` applies
to any newly added field as well. While running this test locally, I can see
assertion results like below
```
2023-04-12 10:37:10,362 INFO fs.TestFileSystemStorageStatistics
(TestFileSystemStorageStatistics.java:testGetLong(99)) - remoteReadTimeMS:
FileSystem.Statistics=75, FileSystemStorageStatistics=75
2023-04-12 10:37:10,353 INFO fs.TestFileSystemStorageStatistics
(TestFileSystemStorageStatistics.java:testGetLongStatistics(88)) -
remoteReadTimeMS: FileSystem.Statistics=10, FileSystemStorageStatistics=10
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
