[ 
https://issues.apache.org/jira/browse/HADOOP-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220531#comment-13220531
 ] 

Sanjay Radia commented on HADOOP-8101:
--------------------------------------

* src/core/org/apache/hadoop/fs/RawLocalFileSystem.java
Why set the status (U,G, etc) to null – don’t you want the actual permission 
for the user, group and world. There is no concept of groups in widows and 
elsewhere you have used a group called "Users".
* src/core/org/apache/hadoop/io/SecureIOUtils.java
if RawLocalFile is fixed then you will not need this.
* src/core/org/apache/hadoop/security/UserGroupInformation.java
** newLoginContext() Patch screwed up – you must have accidently picked up the 
change from HADOOP-7982
** getCurrentUser() – the existing code should work - should not need a 
WINDOWS-os check
* src/core/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
The right way is to use a java class to get the windows group and make the 
default windows config point to this class for getting group mappings. If this 
is the only place where we have a need for different default config for windows 
I could live with the patch.
* src/core/org/apache/hadoop/security/Credentials.java
Job tokens are set for both secure and non-secure. This change should not be 
needed. Did things break without this change?


                
> Security changes for Hadoop for Windows
> ---------------------------------------
>
>                 Key: HADOOP-8101
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8101
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: native
>            Reporter: Sanjay Radia
>         Attachments: security.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to