xBis7 commented on code in PR #5540:
URL: https://github.com/apache/hadoop/pull/5540#discussion_r1167583237
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIdentityProviders.java:
##########
@@ -71,12 +73,20 @@ public void testPluggableIdentityProvider() {
@Test
public void testUserIdentityProvider() throws IOException {
UserIdentityProvider uip = new UserIdentityProvider();
- String identity = uip.makeIdentity(new FakeSchedulable());
+ FakeSchedulable fakeSchedulable = new FakeSchedulable();
+ String identity = uip.makeIdentity(fakeSchedulable);
// Get our username
UserGroupInformation ugi = UserGroupInformation.getCurrentUser();
String username = ugi.getUserName();
assertEquals(username, identity);
+
+ // FakeSchedulable doesn't override getCallerContext()
+ // accessing it should throw a NotImplementedException
+ NotImplementedException nie = assertThrows(
Review Comment:
Thanks for letting me know. I'll use that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
