tomicooler commented on code in PR #5560:
URL: https://github.com/apache/hadoop/pull/5560#discussion_r1170825511


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -196,6 +196,11 @@ public void initialize(URI uri, Configuration 
configuration)
 
     final AbfsConfiguration abfsConfiguration = abfsStore
         .getAbfsConfiguration();
+
+    // Ensures that configuration excludes incompatible credential providers

Review Comment:
   Done.
   
   Note: there is 2x `excludeIncompatibleCredentialProviders` calls, because 
the AbfsConfiguration does it again. Another approach would be to move the 
`super.initialize` after the `AbfsConfiguration` is ready, there is a v1 patch 
uploaded to this PR, check that version too. The v2 is simpler and it's less 
error prone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to