ayushtkn commented on code in PR #5431: URL: https://github.com/apache/hadoop/pull/5431#discussion_r1171540457
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/TimelineServer.md: ########## @@ -833,13 +833,13 @@ Use the following URI to obtain the event objects of the given `entityType`. 1. `entityId` - The entity IDs to retrieve events for. If null, no events will be returned. Multiple entityIds can be given as comma separated values. -1. `limit` - A limit on the number of events to return for each entity. If null, +2. `limit` - A limit on the number of events to return for each entity. If null, defaults to 100 events per entity. -1. `windowStart` - If not null, retrieves only events later than the given time +3. `windowStart` - If not null, retrieves only events later than the given time (exclusive) -1. `windowEnd` - If not null, retrieves only events earlier than the given time +4. `windowEnd` - If not null, retrieves only events earlier than the given time (inclusive) -1. `eventType` - Restricts the events returned to the given types. If null, +5. `eventType` - Restricts the events returned to the given types. If null, Review Comment: I doubt if this is required. Pass me the link from here where it shows messed up http://apache.github.io/hadoop ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/TimelineServer.md: ########## @@ -59,23 +59,23 @@ Generic data is published by the YARN Resource Manager to the timeline store Current status 1. The core functionality of the timeline server has been completed. -1. It works in both secure and non secure clusters. -1. The generic history service is built on the timeline store. -1. The history can be stored in memory or in a leveldb database store; +2. It works in both secure and non secure clusters. +3. The generic history service is built on the timeline store. +4. The history can be stored in memory or in a leveldb database store; the latter ensures the history is preserved over Timeline Server restarts. -1. The ability to install framework specific UIs in YARN is not supported. -1. Application specific information is only available via RESTful APIs using JSON type content. -1. The "Timeline Server v1" REST API has been declared one of the REST APIs +5. The ability to install framework specific UIs in YARN is not supported. +6. Application specific information is only available via RESTful APIs using JSON type content. +7. The "Timeline Server v1" REST API has been declared one of the REST APIs whose compatibility will be maintained in future releases. -1. The single-server implementation of the Timeline Server places a limit on +8. The single-server implementation of the Timeline Server places a limit on the scalability of the service; it also prevents the service being High-Availability component of the YARN infrastructure. Future Plans 1. Future releases will introduce a next generation timeline service which is scalable and reliable, ["Timeline Service v2"](./TimelineServiceV2.html). -1. The expanded features of this service *may not* be available to +2. The expanded features of this service *may not* be available to Review Comment: this sounds correct only, the numbering is correct only http://apache.github.io/hadoop/hadoop-yarn/hadoop-yarn-site/TimelineServer.html ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/DevelopYourOwnDevicePlugin.md: ########## @@ -139,7 +139,7 @@ public interface DevicePluginScheduler { } ``` The above code shows the `DevicePluginScheduler` interface that you might -needed if you want to arm the plugin with a more efficient scheduler. +be needed if you want to arm the plugin with a more efficient scheduler. Review Comment: does this sound better? ``` The above code shows the you might need `DevicePluginScheduler` interface if you want to arm the plugin with a more efficient scheduler. ``` ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/FairScheduler.md: ########## @@ -146,7 +146,7 @@ The allocation file must be in XML format. The format contains five types of ele * **A reservation-planner element**: which sets the class name of the implementation of the `Planner`, which is invoked if the `Plan` capacity fall below (due to scheduled maintenance or node failuers) the user reserved resources. The default value is `org.apache.hadoop.yarn.server.resourcemanager.reservation.planning.SimpleCapacityReplanner`, which scans the `Plan` and greedily removes reservations in reversed order of acceptance (LIFO) till the reserved resources are within the `Plan` capacity. -* **A queuePlacementPolicy element**: which contains a list of rule elements that tell the scheduler how to place incoming apps into queues. Rules are applied in the order that they are listed. Rules may take arguments. All rules accept the "create" argument, which indicates whether the rule can create a new queue. "Create" defaults to true; if set to false and the rule would place the app in a queue that is not configured in the allocations file, we continue on to the next rule. The last rule must be one that can never issue a continue. Valid rules are: +* **A queuePlacementPolicy element**: which contains a list of rule elements that tell the scheduler how to place incoming apps into queues. Rules are applied in the order that they are listed. Rules may take arguments. All rules accept the "create" argument, which indicates whether the rule can create a new queue. "Create" defaults to true; if set to false and the rule would place the app in a queue that is not configured in the allocations file, we continue on to the next rule. The last rule must be one that can never issue a continued. Valid rules are: Review Comment: continue to continued?Is that a command which is continued but not continue, can you pass me the link to that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
