virajjasani commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1171870853
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java:
##########
@@ -47,6 +47,7 @@ public final class CallerContext {
// field names
public static final String CLIENT_IP_STR = "clientIp";
public static final String CLIENT_PORT_STR = "clientPort";
+ public static final String DFSROUTER_PORT_STR = "dfsrouterPort";
Review Comment:
@LiuGuH if this comment is addressed, then also things look good IMO.
The point is both `dfsrouterPort` and using `isClientPortInfoAbsent()` to
set it in the audit logs, together seems fragile because anyone in future
passes clientPort in the context and will get dfsrouterPort printed, which is
not correct for non-router usecases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
