ayushtkn commented on code in PR #5200:
URL: https://github.com/apache/hadoop/pull/5200#discussion_r1173115347
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java:
##########
@@ -979,7 +979,10 @@ public boolean complete(String src, String clientName,
ExtendedBlock last, long fileId)
throws IOException {
checkNNStartup();
- return namesystem.completeFile(src, clientName, last, fileId);
+ boolean result = namesystem.completeFile(src, clientName, last, fileId);
+ LOG.debug("*DIR* NameNode.complete: src={}, clientName={}, fileId={},
result={}.",
+ src, clientName, fileId, result);
+ return result;
Review Comment:
The `namesystem.completeFile` already logs in into the stateChange log
```
NameNode.stateChangeLog.info("DIR* completeFile: " + src
+ " is closed by " + holder);
```
I don't think you need this change in this scope. In general complete
changes the Fs state so it uses ``stateChangeLog`` if any API changes block
state it uses ``blockStateChangeLog`` for rest snapshot or EC operations it is
normal log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
