[
https://issues.apache.org/jira/browse/HADOOP-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715141#comment-17715141
]
ASF GitHub Bot commented on HADOOP-18714:
-----------------------------------------
ayushtkn commented on code in PR #5578:
URL: https://github.com/apache/hadoop/pull/5578#discussion_r1174097084
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRootDirectoryTest.java:
##########
@@ -197,7 +197,7 @@ public void testListEmptyRootDirectory() throws IOException
{
}
FileStatus[] rootListStatus = fs.listStatus(root);
assertEquals("listStatus on empty root-directory returned found: "
- + join("\n", rootListStatus),
+ + join(rootListStatus, "\n"),
0, rootListStatus.length);
Review Comment:
Can we do this? rather than normal joins
```
Assertions.assertThat(rootListStatus).hasSize(0);
```
It does give similar trace and looks better :)
```
java.lang.AssertionError:
Expected size:<0> but was:<1> in:
<[HdfsLocatedFileStatus{path=hdfs://localhost:51193/test; isDirectory=true;
modification_time=1682104954707; access_time=0; owner=ayushsaxena;
group=supergroup; permission=rwxr-xr-x; isSymlink=false; hasAcl=false;
isEncrypted=false; isErasureCoded=false}]>
```
> Wrong StringUtils.join() called in AbstractContractRootDirectoryTest
> --------------------------------------------------------------------
>
> Key: HADOOP-18714
> URL: https://issues.apache.org/jira/browse/HADOOP-18714
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Trivial
> Labels: pull-request-available
>
> In the following call to {{StringUtils.join()}}, {{"\n"}} is treated as an
> element, not as a separator:
> {code:title=https://github.com/apache/hadoop/blob/964c1902c8054dfe13c787222a12fb0daf1aaab9/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRootDirectoryTest.java#L199-L201}
> assertEquals("listStatus on empty root-directory returned found: "
> + join("\n", rootListStatus),
> 0, rootListStatus.length);
> {code}
> Expected output:
> {code}
> [ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.711
> s <<< FAILURE! - in
> org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
> [ERROR]
> testListEmptyRootDirectory(org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory)
> Time elapsed: 0.011 s <<< FAILURE!
> java.lang.AssertionError: listStatus on empty root-directory returned found:
> HdfsLocatedFileStatus{path=hdfs://localhost:37225/test; isDirectory=true;
> ...} expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
> at org.junit.Assert.assertEquals(Assert.java:647)
> at
> org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:199)
> {code}
> Actual output:
> {code}
> [ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.708
> s <<< FAILURE! - in
> org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
> [ERROR]
> testListEmptyRootDirectory(org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory)
> Time elapsed: 0.011 s <<< FAILURE!
> java.lang.AssertionError:
> listStatus on empty root-directory returned found:
> [Lorg.apache.hadoop.fs.FileStatus;@73344c46 expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
> at org.junit.Assert.assertEquals(Assert.java:647)
> at
> org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:199)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
