ayushtkn commented on code in PR #5329:
URL: https://github.com/apache/hadoop/pull/5329#discussion_r1175194686
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java:
##########
@@ -655,8 +655,11 @@ private int sendPacket(ByteBuffer pkt, int maxChunks,
OutputStream out,
if (ioem.startsWith(EIO_ERROR)) {
throw new DiskFileCorruptException("A disk IO error occurred", e);
}
+ String causeMessage = e.getCause() != null ?
e.getCause().getMessage() : "";
if (!ioem.startsWith("Broken pipe")
- && !ioem.startsWith("Connection reset")) {
+ && !ioem.startsWith("Connection reset")
+ && !causeMessage.startsWith("Broken pipe")
+ && !causeMessage.startsWith("Connection reset")) {
Review Comment:
Was going to hit the merge button, got a doubt here. I think we don't have a
null check for ``causeMessage``
we should add one
either do
```causeMessage = causeMessage == null ? "" : causeMessage;```
before the assertions or change the if like
```
if (!ioem.startsWith("Broken pipe")
&& !ioem.startsWith("Connection reset")
&& (causeMessage == null
|| (!causeMessage.startsWith("Broken pipe")
&& !causeMessage.startsWith("Connection reset")))) {
```
check whichever way looks better, double check the if condition if you plan
to use it, I didn't mess up AND with OR, some brackets or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
