[ 
https://issues.apache.org/jira/browse/HADOOP-18424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715800#comment-17715800
 ] 

ASF GitHub Bot commented on HADOOP-18424:
-----------------------------------------

steveloughran commented on code in PR #4809:
URL: https://github.com/apache/hadoop/pull/4809#discussion_r1175269165


##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java:
##########
@@ -101,5 +108,29 @@ public void testArrayWritableStringConstructor() {
     assertArrayEquals("testArrayWritableStringConstructor toString error!!!",
       original, arrayWritable.toStrings());
   }
+
+  @Test
+  public void testArrayWritableStrings() throws Exception {
+    String[] original = {"The 1896 Cedar Keys hurricane was a powerful 
tropical cyclone " +

Review Comment:
   don't think we should be using wikipedia text even if it's interesting. just 
use something from our own docs





> Fix org.apache.hadoop.io.ArrayWritable
> --------------------------------------
>
>                 Key: HADOOP-18424
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18424
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.3.4
>            Reporter: daimin
>            Priority: Major
>              Labels: pull-request-available
>
> When we store an array of string with "new ArrayWritable(String[] strings)", 
> the "valueClass" will be "Text" while the actual value type is "UTF8". This 
> will cause an error on deserialization of ArrayWritable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to