[
https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716211#comment-17716211
]
ASF GitHub Bot commented on HADOOP-18695:
-----------------------------------------
steveloughran commented on code in PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176328084
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditIntegration.java:
##########
@@ -142,4 +144,20 @@ public static <T extends HandlerContextAware> void
attachSpanToRequest(
request.addHandlerContext(AUDIT_SPAN_HANDLER_CONTEXT, span);
}
+ /**
+ * Translate an audit exception.
+ * @param path path of operation.
+ * @param exception exception
+ * @return the IOE to raise.
+ */
+ public static IOException translateAuditException(String path,
+ AuditFailureException exception) {
+ if (exception instanceof AuditOperationRejectedException) {
+ // special handling of this subclass
+ return new UnsupportedRequestException(path,
+ exception.getMessage(), exception);
+ }
+ return (AccessDeniedException)new AccessDeniedException(path, null,
Review Comment:
that's the way it was before when the auditor rejected a request, e.g. an
unaudited operation (with such calls forbidden). just moved from S3AUtils
> S3A: reject multipart copy requests when disabled
> -------------------------------------------------
>
> Key: HADOOP-18695
> URL: https://issues.apache.org/jira/browse/HADOOP-18695
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Labels: pull-request-available
>
> follow-on to HADOOP-18637 and support for huge file uploads with stores which
> don't support MPU.
> * prevent use of API against any s3 store when disabled, using logging
> auditor to reject it
> * tests to verify rename of huge files still works (by setting large part
> size)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
