steveloughran commented on code in PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#discussion_r1176462742
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java:
##########
@@ -257,11 +309,28 @@ public void test_010_CreateHugeFile() throws IOException {
verifyStatisticGaugeValue(iostats, putRequestsActive.getSymbol(), 0);
verifyStatisticGaugeValue(iostats,
STREAM_WRITE_BLOCK_UPLOADS_BYTES_PENDING.getSymbol(), 0);
+
progress.verifyNoFailures(
"Put file " + fileToCreate + " of size " + filesize);
- if (streamStatistics != null) {
- assertEquals("actively allocated blocks in " + streamStatistics,
- 0, streamStatistics.getBlocksActivelyAllocated());
+ assertEquals("actively allocated blocks in " + streamStatistics,
+ 0, streamStatistics.getBlocksActivelyAllocated());
+
+ if (!expectImmediateFileVisibility()) {
Review Comment:
actually, can do it all in the test_030 asserts if I make the filesize field
visible through a getter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
