steveloughran commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1177727496
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/stages/CommitJobStage.java:
##########
@@ -67,98 +71,118 @@ protected CommitJobStage.Result executeStage(
getJobId(),
storeSupportsResilientCommit());
- boolean createMarker = arguments.isCreateMarker();
+ // once the manifest has been loaded, a temp file needs to be
+ // deleted; so track teh value.
+ LoadedManifestData loadedManifestData = null;
+
+ try {
+ boolean createMarker = arguments.isCreateMarker();
+ IOStatisticsSnapshot heapInfo = new IOStatisticsSnapshot();
+ addHeapInformation(heapInfo, "setup");
+ // load the manifests
+ final StageConfig stageConfig = getStageConfig();
+ LoadManifestsStage.Result result = new
LoadManifestsStage(stageConfig).apply(
Review Comment:
already done in AbstractJobOrTaskStage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
