brumi1024 commented on code in PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#discussion_r1180225027
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractLeafQueue.java:
##########
@@ -644,8 +644,8 @@ public void validateSubmitApplication(ApplicationId
applicationId,
!(this instanceof AutoCreatedLeafQueue)) {
String msg =
"Queue " + getQueuePath() + " already has " + getNumApplications()
- + " applications,"
- + " cannot accept submission of application: " + applicationId;
+ + " applications, what is more than the max " +
getMaxApplications()
+ + ", so cannot accept submission of application: " +
applicationId;
Review Comment:
This message is misleading, because exceeding the max applications is not
the only reason why this could be logged and an AccessControlException can be
thrown. I don't think we should log this.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHAForAsyncScheduler.java:
##########
@@ -87,6 +88,7 @@ public void testAsyncScheduleThreadStateAfterRMHATransit()
throws Exception {
startRMs();
// register NM
MockNM nm = rm1.registerNode("192.1.1.1:1234", 8192, 8);
+ CapacitySchedulerTestUtilities.getCapacityScheduler(rm1, 8,8);
Review Comment:
The parameters 8, 8 seem arbitrary, especially because the line above uses
MBs - can you please introduce variables and use the same prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
