ayushtkn commented on code in PR #5603:
URL: https://github.com/apache/hadoop/pull/5603#discussion_r1181071239
##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/util/DistCpUtils.java:
##########
@@ -592,10 +592,14 @@ public static CopyMapper.ChecksumComparison
checksumsAreEqual(
// comparison that took place and return not compatible.
// else if matched, return compatible with the matched result.
if (sourceChecksum == null || targetChecksum == null) {
+ LOG.error("Checksum incompatible. Source checksum: {}, target checksum:
{}",
+ sourceChecksum, targetChecksum);
return CopyMapper.ChecksumComparison.INCOMPATIBLE;
} else if (sourceChecksum.equals(targetChecksum)) {
return CopyMapper.ChecksumComparison.TRUE;
}
+ LOG.error("Checksum not equal. Source checksum: {}, target checksum: {}",
+ sourceChecksum, targetChecksum);
Review Comment:
Error seems to much for this case, info should be more than enough for these
cases, and I don't think we need to put the checksum in the log, rather put the
``sourcePath`` and ``targetPath``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
