tomicooler commented on code in PR #5644:
URL: https://github.com/apache/hadoop/pull/5644#discussion_r1192532531
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/QueueMetrics.java:
##########
@@ -117,6 +117,8 @@ public class QueueMetrics implements MetricsSource {
@Metric("Reserved CPU in virtual cores") MutableGaugeInt reservedVCores;
@Metric("# of reserved containers") MutableGaugeInt reservedContainers;
+ public static final String CONFIGURATION_VALIDATION =
"yarn.configuration-validation";
Review Comment:
At first I put it in the `CapacitySchedulerConfiguration`, but then I
realised that the `QueueMetrics` (not the `CSQueueMetrics`) should not depend
on anything from CS.
We don't really need a config property, and it should not be a public facing
property either. But the Configuration object is shared and propagated
everywhere were we need to check if we are in validation mode (`QueueMetrics`
for the `PartitionQueueMetrics` and `CSQueueMetrics`). Not sure where else to
propagate this flag, without introducing a dependency in `QueueMetrics` to
`CapacitySechduler` related logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
