slfan1989 commented on code in PR #5651:
URL: https://github.com/apache/hadoop/pull/5651#discussion_r1196619861


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/ConfiguredRMFailoverProxyProvider.java:
##########
@@ -119,4 +122,31 @@ public synchronized void close() throws IOException {
       }
     }
   }
+
+  /**
+   * YARN Federation mode, the Router is considered as an RM for the client.
+   * We want the client to be able to randomly
+   * Select a Router and support failover when selecting a Router.
+   * The original code always started trying from the first
+   * Router when the client selected a Router,
+   * but this method will support random Router selection.
+   *
+   * For clusters that have not enabled Federation mode, the behavior remains 
unchanged.
+   *
+   * @param conf Configuration.
+   * @return rmIds
+   */
+  private Collection<String> getRandomOrder(Configuration conf) {

Review Comment:
   I renamed the method for better understanding.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to