ayushtkn commented on code in PR #3743:
URL: https://github.com/apache/hadoop/pull/3743#discussion_r1197468307
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -1129,6 +1129,14 @@ public void refreshNodes() throws IOException {
rpcClient.invokeConcurrent(nss, method, true, true);
}
+ @Override
+ public void refreshTopology() throws IOException {
+ // Router not support this operation, because this maybe refresh multi
namespaces
+ String methodName = RouterRpcServer.getMethodName();
+ throw new UnsupportedOperationException(
+ "Operation \"" + methodName + "\" is not supported");
+ }
+
Review Comment:
in case of router it should delegate the request to all namespaces, that is
how all other commands of similar nature work
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:
##########
@@ -1281,6 +1282,57 @@ nodes with its data cleared (or user can just remove the
StorageID
}
}
+ /**
+ * refresh the network topology of this cluster based on the
mapping_topology.data file.
+ */
+ public void refreshTopology() throws IOException {
+ long start = System.currentTimeMillis();
Review Comment:
use Time.monotonicNow for duration calculations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
