p-szucs opened a new pull request, #5670:
URL: https://github.com/apache/hadoop/pull/5670
Change-Id: I0bf3a80ad3eb3321a875da7e898459208a883551
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
- I tested the solution and I found a case when HDFS was in safe mode during
the time that I restarted RM, and as the root directory already existed in this
case, we didn't catch the SafeModeException. For that I left only the "mkdirs"
command in the try block, similar to the original logic. This way my testing
was successful, the RM waited until HDFS left the safe mode, then became active
again
- Extracted the root directory creation logic to a separate method
- In the unit tests I also mocked the behaviour when SafeModeException
occurs during the root directory creation
### How was this patch tested?
My testings in a cluster:
- manually enabled safe mode in HDFS to trigger SafeModeException
- restarted RM to trigger FS node store initialization
- RM waited in initializing state
- after I disabled safe mode, node store initialization finished and RM
became active again
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
