K0K0V0K commented on code in PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#discussion_r1197813039
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestLeafQueue.java:
##########
@@ -243,9 +246,14 @@ private void setUpInternal(ResourceCalculator rC, boolean
withNodeLabels)
ROOT,
queues, queues,
TestUtils.spyHook);
- mockCsQm.setRootQueue(root);
+ when(mockCsQm.getRootQueue()).thenReturn(root);
Review Comment:
I am not sure, as far as i know call a setter on a mockito object does not
work as the author expected it.
The prod code changeg and now we need this getRootQueue method, what was not
set in this test previously.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestLeafQueue.java:
##########
@@ -3715,7 +3804,7 @@ public void testLocalityDelaysAfterQueueRefresh() throws
Exception {
assertEquals(600, e.getRackLocalityAdditionalDelay());
}
- @Test (timeout = 30000)
+ @Test (timeout = 300000)
Review Comment:
nope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
