ayushtkn commented on code in PR #5569:
URL: https://github.com/apache/hadoop/pull/5569#discussion_r1198427215
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeResourcePolicy.java:
##########
@@ -73,6 +78,11 @@ static boolean areResourcesAvailable(
// required resources available.
return requiredResourceCount > 0;
} else {
+ if (minimumRedundantResources > resources.size()){
+ LOG.info("Resource not available. Details: redundantResourceCount=" +
redundantResourceCount
+ + ", disabledRedundantResourceCount=" +
disabledRedundantResourceCount
+ + ", minimumRedundantResources=" + minimumRedundantResources +
".");
+ }
return redundantResourceCount - disabledRedundantResourceCount >=
minimumRedundantResources;
Review Comment:
Change it to
```
final boolean areResourceAvailable =
redundantResourceCount - disabledRedundantResourceCount >=
minimumRedundantResources;
if (!areResourceAvailable) {
LOG.info("Resources not available. Details:
redundantResourceCount={},"
+ " disabledRedundantResourceCount={},
minimumRedundantResources={}.",
redundantResourceCount, disabledRedundantResourceCount,
minimumRedundantResources);
}
return areResourceAvailable;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
