szilard-nemeth commented on PR #5638: URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1555435928
Hi @ferdelyi , I added a couple of review comments. Could you please also add comments to the test class (e.g. in javadoc) about how the added certificate files, keystore and truststore files were generated, for example you may also add the commands that created those files. As a reader of the test class, I woulnd't have any idea how those files got there and if any issue comes up in the future, the javadoc would tell. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
