virajjasani commented on code in PR #5503:
URL: https://github.com/apache/hadoop/pull/5503#discussion_r1199923215
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java:
##########
@@ -349,7 +348,7 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response
}
if (GenericsUtil.isLog4jLogger(logName)) {
Review Comment:
Thanks @Apache9 for raising this point btw.
let me paste my
[comment](https://issues.apache.org/jira/browse/HADOOP-16206?focusedCommentId=17702846&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17702846)
from parent jira, the jira has too many comments so can be easily ignored :)
_FYI, we use some of the core log4j APIs specifically meant to be used for
properties based config and log4j2 has this support removed as they were meant
to be private usage. Moreover, we also programmatically set monitor interval
for dynamic log4j file changes in httpfs server. This is also no longer
supported as that is also meant to be kept in config only (properties, xml,
json, yaml etc)._
_I have started this thread with log4j dev/user group for the same
https://lists.apache.org/thread/4l7oyk84jpj6br0sn4ymofdcbgfxmtqp_
_So far, the only recommended solution provided by them is to configure
monitor interval in log4j properties only (i.e. user provided custom log4j
properties, in case of httpfs Server), and use Configurator API for the
properties file specific usage we have._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
