GauthamBanasandra commented on code in PR #5688:
URL: https://github.com/apache/hadoop/pull/5688#discussion_r1205934232
##########
hadoop-project-dist/pom.xml:
##########
@@ -106,7 +106,7 @@
<source>${maven.compile.source}</source>
<charset>${maven.compile.encoding}</charset>
<reportOutputDirectory>${project.build.directory}/site</reportOutputDirectory>
- <destDir>${project.build.directory}/api</destDir>
+ <destDir>api</destDir>
Review Comment:
Thanks for the review @ayushtkn.
> And I think it isn't going there either, it going inside site/apidocs
rather than site/api
The `hadoop-hdfs-httpfs` module doesn't inherit from `hadoop-project-dist`.
So, its `maven-javadoc-plugin` configuration must be coming from somewhere else
that points to `site/apidocs`. However, I couldn't find any relevant reference
to `site/apidocs` in the Hadoop codebase (I'm thinking it's a default value
that's kicking in here).
> Can we not do ../api and maintain the behaviour? And I think it isn't
going there either,
The javadoc is getting generated inside `${project.build.directory}/api` for
me when I use `../api` -
```powershell
PS C:\Users\Gautham> Get-ChildItem -Recurse -Filter 'target\api' -Path H:
-ErrorAction SilentlyContinue | foreach { $_.FullName } | where {
(Get-ChildItem $_).Count -gt 0 }
H:\hadoop-hdfs-project\hadoop-hdfs\target\api
H:\hadoop-hdfs-project\hadoop-hdfs-client\target\api
H:\hadoop-hdfs-project\hadoop-hdfs-rbf\target\api
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
