goiri commented on code in PR #5694:
URL: https://github.com/apache/hadoop/pull/5694#discussion_r1209485344
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionContext.java:
##########
@@ -170,7 +170,9 @@ public String toString() {
Class<?> clazz = proxy.getClass();
StringBuilder sb = new StringBuilder();
- sb.append(clazz.getSimpleName())
+ sb.append("hashcode:")
+ .append(hashCode() + " ")
Review Comment:
The point of the StringBuilder is to not use +.
```
.append(hashCode())
.append(" ")
```
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java:
##########
@@ -482,7 +482,7 @@ public void run() {
pool.getMaxSize(), pool);
}
} catch (IOException e) {
- LOG.error("Cannot create a new connection", e);
+ LOG.error("Cannot create a new connection for " + pool, e);
Review Comment:
Use {}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
