[
https://issues.apache.org/jira/browse/HADOOP-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727650#comment-17727650
]
ASF GitHub Bot commented on HADOOP-18755:
-----------------------------------------
steveloughran opened a new pull request, #5704:
URL: https://github.com/apache/hadoop/pull/5704
Add defaults for everything, so all an impl needs to do is the opt(key,
string), opt(key, strings) and the must variants
remove `final` from the opt(string, double) and float variants (and `must`
equivalents)
Modified test case to use a minimal impl relying on the defaults, so
ensuring there's never any backwards incompatibility.
One interesting issue here: should we cut the implementations of the
now-defaulted new methods? this ensures consistency everywhere.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> openFile builder new optLong() methods break hbase-filesystem
> -------------------------------------------------------------
>
> Key: HADOOP-18755
> URL: https://issues.apache.org/jira/browse/HADOOP-18755
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.3.9
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
>
> The new methods of HADOOP-18724 break builds of hbase filesystem because
> HBASE-26483 added an implementation of the interface, which,
> because it lacks the complete methods, doesn't compile any more.
> It also marked the (deprecated) methods as final in the base implementation,
> which is also a source of pain.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
